Commit-ID: fa9833992d5ff3c0d6e81d708bec363bce2fb54c Gitweb: https://git.kernel.org/tip/fa9833992d5ff3c0d6e81d708bec363bce2fb54c Author: Thomas Gleixner <[email protected]> AuthorDate: Wed, 10 Apr 2019 12:28:00 +0200 Committer: Thomas Gleixner <[email protected]> CommitDate: Sun, 14 Apr 2019 19:58:28 +0200
riscv/stacktrace: Remove the pointless ULONG_MAX marker Terminating the last trace entry with ULONG_MAX is a completely pointless exercise and none of the consumers can rely on it because it's inconsistently implemented across architectures. In fact quite some of the callers remove the entry and adjust stack_trace.nr_entries afterwards. Signed-off-by: Thomas Gleixner <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Cc: Josh Poimboeuf <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: Steven Rostedt <[email protected]> Cc: Alexander Potapenko <[email protected]> Cc: [email protected] Cc: Palmer Dabbelt <[email protected]> Cc: Albert Ou <[email protected]> Link: https://lkml.kernel.org/r/[email protected] --- arch/riscv/kernel/stacktrace.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/riscv/kernel/stacktrace.c b/arch/riscv/kernel/stacktrace.c index a4b1d94371a0..4d403274c2e8 100644 --- a/arch/riscv/kernel/stacktrace.c +++ b/arch/riscv/kernel/stacktrace.c @@ -169,8 +169,6 @@ static bool save_trace(unsigned long pc, void *arg) void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) { walk_stackframe(tsk, NULL, save_trace, trace); - if (trace->nr_entries < trace->max_entries) - trace->entries[trace->nr_entries++] = ULONG_MAX; } EXPORT_SYMBOL_GPL(save_stack_trace_tsk);
