Hi Jesper, On 8/9/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > EHLO, > > If, in em28xx_usb_probe() the memory allocation > dev->alt_max_pkt_size = kmalloc(32* > dev->num_alt,GFP_KERNEL); > fails, then we'll bail out and return -ENOMEM. > The problem is that in that case we don't free the storage allocated > to 'dev', thus causing a memory leak. > > This patch fixes the leak by freeing 'dev' before we return -ENOMEM. > This fixes Coverity bug #647. > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-by: Markus Rechberger <[EMAIL PROTECTED]> thanks, Markus > --- > > drivers/media/video/em28xx/em28xx-video.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/video/em28xx/em28xx-video.c > b/drivers/media/video/em28xx/em28xx-video.c > index 2c7b158..40307f3 100644 > --- a/drivers/media/video/em28xx/em28xx-video.c > +++ b/drivers/media/video/em28xx/em28xx-video.c > @@ -1772,6 +1772,7 @@ static int em28xx_usb_probe(struct usb_interface > *interface, > if (dev->alt_max_pkt_size == NULL) { > em28xx_errdev("out of memory!\n"); > em28xx_devused&=~(1<<nr); > + kfree(dev); > return -ENOMEM; > } > > > > > -- Markus Rechberger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/