On Tue 2019-04-16 09:48:51, Ulf Hansson wrote: > On Fri, 12 Apr 2019 at 11:34, Pavel Machek <[email protected]> wrote: > > > > !voltage_ranges is tested for too late, allowing warning and undefined > > behavior. Fix that. > > > > Signed-off-by: Pavel Machek <[email protected]> > > Pavel, thanks for your patch. > > Would you mind re-posting to linux-mmc so I can get it into the > patchtracker. Please also change the prefix of the header to "mmc: > core:".
Done.
> > Plus I guess author should add parenthesis in the expression. a / b /
> > c is _not_ common idiom.
Can you do something about the a / b / c situation?
> > - num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
> > + num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
I guess it is:
num_ranges = (num_ranges / sizeof(*voltage_ranges)) / 2;
...but...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
