In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch aims to suppress 3 missing-break-in-switch false positives on some architectures. Acked-by: Arnd Bergmann <[email protected]> Cc: Deepa Dinamani <[email protected]> Cc: Gustavo A. R. Silva <[email protected]> Cc: Kees Cook <[email protected]> Cc: Jann Horn <[email protected]> Signed-off-by: Stephen Rothwell <[email protected]> --- kernel/compat.c | 3 +++ 1 file changed, 3 insertions(+) v2 - split the comments on to new lines to match commit 89976005536c ("include/linux/compat.h: mark expected switch fall-throughs"). (Arnd Bergmann) diff --git a/kernel/compat.c b/kernel/compat.c index d8a36c6ad7c9..b5f7063c0db6 100644 --- a/kernel/compat.c +++ b/kernel/compat.c @@ -346,8 +346,11 @@ get_compat_sigset(sigset_t *set, const compat_sigset_t __user *compat) return -EFAULT; switch (_NSIG_WORDS) { case 4: set->sig[3] = v.sig[6] | (((long)v.sig[7]) << 32 ); + /* fall through */ case 3: set->sig[2] = v.sig[4] | (((long)v.sig[5]) << 32 ); + /* fall through */ case 2: set->sig[1] = v.sig[2] | (((long)v.sig[3]) << 32 ); + /* fall through */ case 1: set->sig[0] = v.sig[0] | (((long)v.sig[1]) << 32 ); } #else -- 2.20.1 -- Cheers, Stephen Rothwell
pgptvqYfhRYDx.pgp
Description: OpenPGP digital signature
