On 16/04/2019 18:32, Moses Christopher wrote:
> - In drivers/clocksource/timer-probe.c, the log level for the message
> stating "no matching timers found" should be informational rather
> than critical.
> - Reference:
> - https://e2e.ti.com/support/processors/f/791/t/726024
Thanks for the pointer.
Actually in most of the cases when there are no timers found after this
sequence it is because a definition is missing in the DT or the timer
was not able to initialize and we end up with a stuck board at boot time.
May be pr_warn would be more appropriate in this case.
However, if this omap board can boot without DT defined timers, does it
make sense to run the timer-probe code?
> Signed-off-by: Moses Christopher <moseschristoph...@gmail.com>
> ---
> drivers/clocksource/timer-probe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-probe.c
> b/drivers/clocksource/timer-probe.c
> index 028075720334..f0dcb41e079f 100644
> --- a/drivers/clocksource/timer-probe.c
> +++ b/drivers/clocksource/timer-probe.c
> @@ -50,5 +50,5 @@ void __init timer_probe(void)
> timers += acpi_probe_device_table(timer);
>
> if (!timers)
> - pr_crit("%s: no matching timers found\n", __func__);
> + pr_info("%s: no matching timers found\n", __func__);
> }
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
