On Thu, Apr 18, 2019 at 11:07 AM Thomas Gleixner <t...@linutronix.de> wrote: > On Thu, 18 Apr 2019, Miroslav Lichvar wrote: > > On Wed, Apr 17, 2019 at 11:00:23AM +0200, Ondrej Mosnacek wrote: > > > On Wed, Apr 17, 2019 at 10:48 AM Miroslav Lichvar <mlich...@redhat.com> > > > wrote: > > > > Change the ADJ_TAI check to accept zero as a valid TAI-UTC offset in > > > > order to allow setting it back to the initial value. > > > > > Thanks for sending the patch! Maybe you (or the committer) could > > > consider adding: > > > > > > Fixes: 153b5d054ac2 ("ntp: support for TAI") > > > > To me the change looks more like an extension of the API, rather than > > a bug fix, so I'd leave that up to the committer. > > I don't see why we need to backport that all the way, but I'm happy to add > the tag if there is some really good reason.
OK, I can live without it, it's just that it kind of breaks the tests for the recent time auditing patches [1] (I try to reset to previous values when triggering events). I worked around it for now by resetting the value to 1 when original value was 0... I don't know if it can lead to some issues or not, but it would be nice if I could reset to the actual original value... [1] https://github.com/linux-audit/audit-testsuite/pull/82/files#diff-555d96083b536100d9b7e3eea56feadbR76 -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc.