On Wed, Apr 17, 2019 at 7:35 PM Sebastian Reichel <[email protected]> wrote: > > Hi, > > On Fri, Apr 05, 2019 at 12:30:20AM -0700, Andrey Smirnov wrote: > > Fix a similar endless event loop as was done in commit 8dcf32175b4e > > ("i2c: prevent endless uevent loop with CONFIG_I2C_DEBUG_CORE"): > > > > The culprit is the dev_dbg printk in the i2c uevent handler. If > > this is activated (for instance by CONFIG_I2C_DEBUG_CORE) it results > > in an endless loop with systemd-journald. > > > > This happens if user-space scans the system log and reads the uevent > > file to get information about a newly created device, which seems > > fair use to me. Unfortunately reading the "uevent" file uses the > > same function that runs for creating the uevent for a new device, > > generating the next syslog entry > > > > Both CONFIG_I2C_DEBUG_CORE and CONFIG_POWER_SUPPLY_DEBUG were reported > > in https://bugs.freedesktop.org/show_bug.cgi?id=76886 but only former > > seems to have been fixed. Change debug prints to use pr_debug insted > > to resolve the issue. > > > > Signed-off-by: Andrey Smirnov <[email protected]> > > Cc: Chris Healy <[email protected]> > > Cc: Sebastian Reichel <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > --- > > I think we should just drop these debug messages, just like I2C did. > They don't offer any useful information considering the info is already > exposed to userspace via the uevent.
OK, sounds good, will do in v2. Thanks, Andrey Smirnov
