Hi Zhenliang, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.1-rc6 next-20190418] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Zhenliang-Wei/signal-trace_signal_deliver-when-signal_group_exit/20190423-062107 config: i386-randconfig-x010-201916 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All error/warnings (new ones prefixed by >>): In file included from arch/x86/include/uapi/asm/signal.h:94:0, from arch/x86/include/asm/signal.h:36, from include/uapi/linux/signal.h:5, from include/linux/signal_types.h:10, from include/linux/sched.h:28, from include/linux/sched/mm.h:7, from kernel/signal.c:16: kernel/signal.c: In function 'get_signal': >> include/uapi/asm-generic/signal-defs.h:24:17: error: passing argument 3 of >> 'trace_signal_deliver' from incompatible pointer type >> [-Werror=incompatible-pointer-types] #define SIG_DFL ((__force __sighandler_t)0) /* default signal handling */ ^ >> kernel/signal.c:2444:50: note: in expansion of macro 'SIG_DFL' trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL); ^~~~~~~ In file included from include/trace/syscall.h:5:0, from include/linux/syscalls.h:86, from kernel/signal.c:29: include/linux/tracepoint.h:235:21: note: expected 'struct k_sigaction *' but argument is of type 'void (*)(int)' static inline void trace_##name(proto) \ ^ include/linux/tracepoint.h:398:2: note: in expansion of macro '__DECLARE_TRACE' __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \ ^~~~~~~~~~~~~~~ include/linux/tracepoint.h:534:2: note: in expansion of macro 'DECLARE_TRACE' DECLARE_TRACE(name, PARAMS(proto), PARAMS(args)) ^~~~~~~~~~~~~ >> include/trace/events/signal.h:96:1: note: in expansion of macro 'TRACE_EVENT' TRACE_EVENT(signal_deliver, ^~~~~~~~~~~ cc1: some warnings being treated as errors vim +/trace_signal_deliver +24 include/uapi/asm-generic/signal-defs.h b1ecb4c3 include/asm-generic/signal.h Al Viro 2005-05-04 23 b1ecb4c3 include/asm-generic/signal.h Al Viro 2005-05-04 @24 #define SIG_DFL ((__force __sighandler_t)0) /* default signal handling */ b1ecb4c3 include/asm-generic/signal.h Al Viro 2005-05-04 25 #define SIG_IGN ((__force __sighandler_t)1) /* ignore signal */ b1ecb4c3 include/asm-generic/signal.h Al Viro 2005-05-04 26 #define SIG_ERR ((__force __sighandler_t)-1) /* error return from signal */ b1ecb4c3 include/asm-generic/signal.h Al Viro 2005-05-04 27 #endif ad158879 include/asm-generic/signal.h David Woodhouse 2006-04-27 28 :::::: The code at line 24 was first introduced by commit :::::: b1ecb4c3a9e33cc8b93ac9cb046b535b72a15f68 [PATCH] asm/signal.h unification :::::: TO: Al Viro <v...@www.linux.org.uk> :::::: CC: Linus Torvalds <torva...@ppc970.osdl.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip