On Fri, Apr 12, 2019 at 8:01 AM Wen Yang <[email protected]> wrote:

> The call to of_parse_phandle returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./drivers/pinctrl/zte/pinctrl-zx.c:415:2-8: ERROR: missing of_node_put; 
> acquired a node pointer with refcount incremented on line 407, but without a 
> corresponding object release within this function.
> ./drivers/pinctrl/zte/pinctrl-zx.c:422:2-8: ERROR: missing of_node_put; 
> acquired a node pointer with refcount incremented on line 407, but without a 
> corresponding object release within this function.
> ./drivers/pinctrl/zte/pinctrl-zx.c:436:2-8: ERROR: missing of_node_put; 
> acquired a node pointer with refcount incremented on line 407, but without a 
> corresponding object release within this function.
> ./drivers/pinctrl/zte/pinctrl-zx.c:444:2-8: ERROR: missing of_node_put; 
> acquired a node pointer with refcount incremented on line 407, but without a 
> corresponding object release within this function.
> ./drivers/pinctrl/zte/pinctrl-zx.c:448:1-7: ERROR: missing of_node_put; 
> acquired a node pointer with refcount incremented on line 407, but without a 
> corresponding object release within this function.
>
> Signed-off-by: Wen Yang <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Jun Nie <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Patch applied with Shawn's ACK.

Yours,
Linus Walleij

Reply via email to