Hi, On Tue, Apr 23, 2019 at 04:18:05PM +0000 Vineeth Remanan Pillai wrote: > Second iteration of the core-scheduling feature.
Thanks for spinning V2 of this. > > This version fixes apparent bugs and performance issues in v1. This > doesn't fully address the issue of core sharing between processes > with different tags. Core sharing still happens 1% to 5% of the time > based on the nature of workload and timing of the runnable processes. > > Changes in v2 > ------------- > - rebased on mainline commit: 6d906f99817951e2257d577656899da02bb33105 > - Fixes for couple of NULL pointer dereference crashes > - Subhra Mazumdar > - Tim Chen > - Improves priority comparison logic for process in different cpus > - Peter Zijlstra > - Aaron Lu > - Fixes a hard lockup in rq locking > - Vineeth Pillai > - Julien Desfossez > - Fixes a performance issue seen on IO heavy workloads > - Vineeth Pillai > - Julien Desfossez > - Fix for 32bit build > - Aubrey Li > > Issues > ------ > - Processes with different tags can still share the core I may have missed something... Could you explain this statement? This, to me, is the whole point of the patch series. If it's not doing this then ... what? Thanks, Phil > - A crash when disabling cpus with core-scheduling on > - https://paste.debian.net/plainh/fa6bcfa8 > > --- > > Peter Zijlstra (16): > stop_machine: Fix stop_cpus_in_progress ordering > sched: Fix kerneldoc comment for ia64_set_curr_task > sched: Wrap rq::lock access > sched/{rt,deadline}: Fix set_next_task vs pick_next_task > sched: Add task_struct pointer to sched_class::set_curr_task > sched/fair: Export newidle_balance() > sched: Allow put_prev_task() to drop rq->lock > sched: Rework pick_next_task() slow-path > sched: Introduce sched_class::pick_task() > sched: Core-wide rq->lock > sched: Basic tracking of matching tasks > sched: A quick and dirty cgroup tagging interface > sched: Add core wide task selection and scheduling. > sched/fair: Add a few assertions > sched: Trivial forced-newidle balancer > sched: Debug bits... > > Vineeth Remanan Pillai (1): > sched: Wake up sibling if it has something to run > > include/linux/sched.h | 9 +- > kernel/Kconfig.preempt | 7 +- > kernel/sched/core.c | 800 +++++++++++++++++++++++++++++++++++++-- > kernel/sched/cpuacct.c | 12 +- > kernel/sched/deadline.c | 99 +++-- > kernel/sched/debug.c | 4 +- > kernel/sched/fair.c | 137 +++++-- > kernel/sched/idle.c | 42 +- > kernel/sched/pelt.h | 2 +- > kernel/sched/rt.c | 96 +++-- > kernel/sched/sched.h | 185 ++++++--- > kernel/sched/stop_task.c | 35 +- > kernel/sched/topology.c | 4 +- > kernel/stop_machine.c | 2 + > 14 files changed, 1145 insertions(+), 289 deletions(-) > > -- > 2.17.1 > --
