Hi Neil, On Tue, Apr 23, 2019 at 11:16 AM Neil Armstrong <narmstr...@baylibre.com> wrote: > > This patch adds basic support for : > - Amlogic G12B, which is very similar to G12A > - The HardKernel Odroid-N2 based on the S922X SoC > > The Amlogic G12B SoC is very similar with the G12A SoC, sharing > most of the features and architecture, but with these differences : > - The first CPU cluster only has 2xCortex-A53 instead of 4 > - G12B has a second cluster of 4xCortex-A73 > - Both cluster can achieve 2GHz instead of 1,8GHz for G12A > - CPU Clock architecture is difference, thus needing a different > compatible to handle this slight difference > - Supports a MIPI CSI input > - Embeds a Mali-G52 instead of a Mali-G31, but integration is the same > > Actual support is done in the same way as for the GXM support, including > the G12A dtsi and redefining the CPU clusters. > Unlike GXM, the first cluster is different, thus needing to remove > the last 2 cpu nodes of the first cluster. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> I don't have the board myself so I can't test it. However, apart from one comment below this is looking good so: Reviewed-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
[...] > +&usb { > + status = "okay"; > +}; > + > +&usb2_phy0 { > + phy-supply = <&usb_pwr_en>; > +}; is usb_pwr_en really the phy-supply or is it the vbus-supply of the USB top control block (&usb node)? Martin