Ping...
> -----Original Message----- > From: Mukesh Ojha [mailto:mo...@codeaurora.org] > Sent: Monday, April 1, 2019 4:02 PM > To: Anson Huang <anson.hu...@nxp.com>; dmitry.torok...@gmail.com; > shawn...@kernel.org; s.ha...@pengutronix.de; ker...@pengutronix.de; > feste...@gmail.com; linux-in...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org > Cc: dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH] input: imx6ul_tsc: use > devm_platform_ioremap_resource() to simplify code > > > On 4/1/2019 10:49 AM, Anson Huang wrote: > > Use the new helper devm_platform_ioremap_resource() which wraps the > > platform_get_resource() and devm_ioremap_resource() together, to > > simplify the code. > > > > Signed-off-by: Anson Huang <anson.hu...@nxp.com> > > > Reviewed-by: Mukesh Ojha <mo...@codeaurora.org> > > Cheers, > -Mukesh > > > --- > > drivers/input/touchscreen/imx6ul_tsc.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/input/touchscreen/imx6ul_tsc.c > > b/drivers/input/touchscreen/imx6ul_tsc.c > > index c10fc59..e04eecd 100644 > > --- a/drivers/input/touchscreen/imx6ul_tsc.c > > +++ b/drivers/input/touchscreen/imx6ul_tsc.c > > @@ -364,8 +364,6 @@ static int imx6ul_tsc_probe(struct platform_device > *pdev) > > struct device_node *np = pdev->dev.of_node; > > struct imx6ul_tsc *tsc; > > struct input_dev *input_dev; > > - struct resource *tsc_mem; > > - struct resource *adc_mem; > > int err; > > int tsc_irq; > > int adc_irq; > > @@ -403,16 +401,14 @@ static int imx6ul_tsc_probe(struct > platform_device *pdev) > > return err; > > } > > > > - tsc_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - tsc->tsc_regs = devm_ioremap_resource(&pdev->dev, tsc_mem); > > + tsc->tsc_regs = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(tsc->tsc_regs)) { > > err = PTR_ERR(tsc->tsc_regs); > > dev_err(&pdev->dev, "failed to remap tsc memory: %d\n", > err); > > return err; > > } > > > > - adc_mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > - tsc->adc_regs = devm_ioremap_resource(&pdev->dev, adc_mem); > > + tsc->adc_regs = devm_platform_ioremap_resource(pdev, 1); > > if (IS_ERR(tsc->adc_regs)) { > > err = PTR_ERR(tsc->adc_regs); > > dev_err(&pdev->dev, "failed to remap adc memory: %d\n", > err);
