On Sat, Apr 27, 2019 at 08:29:32PM -0700, Yury Norov wrote: > Introduce BITS_TO_U64, BITS_TO_U32 and BITS_TO_BYTES as they are handy > in the following changes (BITS_TO_U32 specifically). Sync tools/ > version of the macros with the kernel implementation.
AFAICS you basically reimplement them for kernel use from tools/. > #define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE) Hmm... no TAB here? Perhaps another small fix can be done. > #define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(long)) > +#define BITS_TO_U64(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u64)) > +#define BITS_TO_U32(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u32)) > +#define BITS_TO_BYTES(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(char)) > > extern unsigned int __sw_hweight8(unsigned int w); > extern unsigned int __sw_hweight16(unsigned int w); > diff --git a/tools/include/linux/bitops.h b/tools/include/linux/bitops.h > index 0b0ef3abc966..959dcb8214ba 100644 > --- a/tools/include/linux/bitops.h > +++ b/tools/include/linux/bitops.h > @@ -13,10 +13,11 @@ > #include <linux/bits.h> > #include <linux/compiler.h> > > -#define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(long)) > -#define BITS_TO_U64(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * > sizeof(u64)) > -#define BITS_TO_U32(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * > sizeof(u32)) > -#define BITS_TO_BYTES(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE) > +#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE) > +#define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(long)) > +#define BITS_TO_U64(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u64)) > +#define BITS_TO_U32(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u32)) > +#define BITS_TO_BYTES(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(char)) -- With Best Regards, Andy Shevchenko
