On Mon, Apr 29, 2019 at 10:03:36AM -0400, Sven Van Asbroeck wrote: > On Mon, Apr 29, 2019 at 2:11 AM Nicholas Mc Guire <hof...@osadl.org> wrote: > > > > V2: As requested by Sven Van Asbroeck <thesve...@gmail.com> make the > > impact of the patch clear in the commit message. > > Thank you, but did you miss my comment about creating a local variable > instead? See: > https://lkml.org/lkml/2019/4/28/97
Did not miss it - I just don't think that makes it any more understandable - the __force __be16 makes it clear I believe that this is correct, sparse does not like this though - so tell sparse. The local variable would need to be explained as it is functionally not necessary - therefor I find it more confusing that using __force here. If that rational is wrong let me know. thx! hofrat
