On 01-05-19, 09:33, Jon Hunter wrote:

> > @@ -1444,12 +1529,7 @@ static int tegra_dma_probe(struct platform_device 
> > *pdev)
> >             BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) |
> >             BIT(DMA_SLAVE_BUSWIDTH_8_BYTES);
> >     tdma->dma_dev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> > -   /*
> > -    * XXX The hardware appears to support
> > -    * DMA_RESIDUE_GRANULARITY_BURST-level reporting, but it's
> > -    * only used by this driver during tegra_dma_terminate_all()
> > -    */
> > -   tdma->dma_dev.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;
> > +   tdma->dma_dev.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> >     tdma->dma_dev.device_config = tegra_dma_slave_config;
> >     tdma->dma_dev.device_terminate_all = tegra_dma_terminate_all;
> >     tdma->dma_dev.device_tx_status = tegra_dma_tx_status;
> 
> In addition to Dmitry's comments, can you please make sure you run this
> through checkpatch.pl?

And use correct subsystem name !

-- 
~Vinod

Reply via email to