On 01-05-19, 17:24, Bjorn Andersson wrote:
> The QCS404 has a PCIe2 PHY and a Qualcomm PCIe controller, add these to
> the platform dtsi and enable them for the EVB with the perst gpio
> and analog supplies defined.
>
> Reviewed-by: Niklas Cassel <niklas.cas...@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org>
> ---
>
> The patch depends on the acceptance of:
> https://lore.kernel.org/lkml/20190502002138.10646-1-bjorn.anders...@linaro.org/
> https://lore.kernel.org/lkml/20190502001406.10431-2-bjorn.anders...@linaro.org/
> https://lore.kernel.org/lkml/20190502001955.10575-3-bjorn.anders...@linaro.org/
>
> Changes since v2:
> - None
>
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 25 +++++++++
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 67 ++++++++++++++++++++++++
I would have preferred the evb changes to follow the node addition but
that is matter of preference :)
> 2 files changed, 92 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 2c3127167e3c..988d21ca0df1 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -68,6 +68,22 @@
> };
> };
>
> +&pcie {
> + status = "ok";
> +
> + perst-gpio = <&tlmm 43 GPIO_ACTIVE_LOW>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&perst_state>;
> +};
> +
> +&pcie_phy {
> + status = "ok";
> +
> + vdda-vp-supply = <&vreg_l3_1p05>;
> + vdda-vph-supply = <&vreg_l5_1p8>;
> +};
> +
> &remoteproc_adsp {
> status = "ok";
> };
> @@ -184,6 +200,15 @@
> };
>
> &tlmm {
> + perst_state: perst {
> + pins = "gpio43";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-disable;
> + output-low;
> + };
> +
> sdc1_on: sdc1-on {
> clk {
> pins = "sdc1_clk";
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index ffedf9640af7..f41feab8996c 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -4,6 +4,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/qcom,gcc-qcs404.h>
> #include <dt-bindings/clock/qcom,rpmcc.h>
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> interrupt-parent = <&intc>;
> @@ -383,6 +384,7 @@
> compatible = "qcom,gcc-qcs404";
> reg = <0x01800000 0x80000>;
> #clock-cells = <1>;
> + #reset-cells = <1>;
But this one doesn't belong here..
Rest lgtm.
--
~Vinod
