Hi, On Thu, Oct 18, 2018 at 11:56 AM Kees Cook <keesc...@chromium.org> wrote: > > From: "Joel Fernandes (Google)" <j...@joelfernandes.org> > > ramoops's call of pstore_register() was recently moved to run during > late_initcall() because the crypto backend may not have been ready during > postcore_initcall(). This meant early-boot crash dumps were not getting > caught by pstore any more. > > Instead, lets allow calls to pstore_register() earlier, and once crypto > is ready we can initialize the compression. > > Reported-by: Sai Prakash Ranjan <saiprakash.ran...@codeaurora.org> > Signed-off-by: Joel Fernandes (Google) <j...@joelfernandes.org> > Tested-by: Sai Prakash Ranjan <saiprakash.ran...@codeaurora.org> > Fixes: cb3bee0369bc ("pstore: Use crypto compress API") > [kees: trivial rebase] > Signed-off-by: Kees Cook <keesc...@chromium.org> > --- > fs/pstore/platform.c | 10 +++++++++- > fs/pstore/ram.c | 2 +- > 2 files changed, 10 insertions(+), 2 deletions(-)
I'd propose that these three patches: 95047b0519c1 pstore: Refactor compression initialization 416031653eb5 pstore: Allocate compression during late_initcall() cb095afd4476 pstore: Centralize init/exit routines Get sent to linux-stable. Specifically I'll mention that 4.19 needs it. IMO the regression of pstore not catching early boot crashes is pretty serious IMO. Thanks! -Doug