* Masami Hiramatsu <[email protected]> wrote:
> --- a/tools/perf/util/probe-event.h
> +++ b/tools/perf/util/probe-event.h
> @@ -37,6 +37,7 @@ struct probe_trace_point {
> struct probe_trace_arg_ref {
> struct probe_trace_arg_ref *next; /* Next reference */
> long offset; /* Offset value */
> + bool user; /* User-memory access */
> };
>
> /* kprobe-tracer and uprobe-tracer tracing argument */
> @@ -82,6 +83,7 @@ struct perf_probe_arg {
> char *var; /* Variable name */
> char *type; /* Type name */
> struct perf_probe_arg_field *field; /* Structure fields */
> + bool user; /* User-memory */
Why did the 'access' qualifier get dropped from the second comment?
Also, please name it and related parameters and local variables
'user_access' - in that case no comments are needed and it's all super
clear. Only 'user' is ambiguous really.
Thanks,
ngo
