From: Colin Ian King <colin.k...@canonical.com>

The variable ret is being initialized however this is never read and later
it is being reassigned to a new value. The initialization is redundant and
hence can be removed.

Addresses-Coverity: ("Unused Value")
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
 drivers/staging/vc04_services/bcm2835-camera/controls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c 
b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 9841c30450ce..74410fedffad 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -579,7 +579,7 @@ static int ctrl_set_colfx(struct bm2835_mmal_dev *dev,
                          struct v4l2_ctrl *ctrl,
                          const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
 {
-       int ret = -EINVAL;
+       int ret;
        struct vchiq_mmal_port *control;
 
        control = &dev->component[MMAL_COMPONENT_CAMERA]->control;
-- 
2.20.1

Reply via email to