On 5/15/19 2:03 AM, Arnd Bergmann wrote: > On Sun, May 12, 2019 at 3:25 AM Alex Elder <el...@linaro.org> wrote: >> >> Add the binding definitions for the "qcom,ipa" device tree node. >> >> Signed-off-by: Alex Elder <el...@linaro.org> >> --- >> .../devicetree/bindings/net/qcom,ipa.txt | 164 ++++++++++++++++++ >> 1 file changed, 164 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/qcom,ipa.txt >> >> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.txt >> b/Documentation/devicetree/bindings/net/qcom,ipa.txt >> new file mode 100644 >> index 000000000000..2705e198f12e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.txt > > For new bindings, we should use the yaml format so we can verify the > device tree files against the binding.
OK. I didn't realize that was upstream yet. I will convert. >> + >> +- reg: >> + Resources specifying the physical address spaces of the IPA and GSI. >> + >> +- reg-names: >> + The names of the two address space ranges defined by the "reg" >> + property. Must be: >> + "ipa-reg" >> + "ipa-shared" >> + "gsi" > > Those are three, not two ;-) Oops! I added one recently and I guess I missed that. Thanks for catching it. -Alex > > Arnd >