On 16/05/2019 22:38, Doug Anderson wrote: > Hi, > > From: kernelci.org bot <b...@kernelci.org> > Date: Tue, May 14, 2019 at 9:06 AM > To: <tomeu.viz...@collabora.com>, <guillaume.tuc...@collabora.com>, > <mga...@collabora.com>, <broo...@kernel.org>, > <matthew.h...@linaro.org>, <khil...@baylibre.com>, > <enric.balle...@collabora.com>, Elaine Zhang, Eduardo Valentin, Daniel > Lezcano > Cc: Heiko Stuebner, <linux...@vger.kernel.org>, > <linux-kernel@vger.kernel.org>, <linux-rockc...@lists.infradead.org>, > Zhang Rui, <linux-arm-ker...@lists.infradead.org> > >> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >> * This automated bisection report was sent to you on the basis * >> * that you may be involved with the breaking commit it has * >> * found. No manual investigation has been done to verify it, * >> * and the root cause of the problem may be somewhere else. * >> * Hope this helps! * >> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >> >> next/master boot bisection: next-20190514 on rk3288-veyron-jaq >> >> Summary: >> Start: 0a13f187b16a Add linux-next specific files for 20190514 >> Details: https://kernelci.org/boot/id/5cda7f2259b514876d7a3628 >> Plain log: >> https://storage.kernelci.org//next/master/next-20190514/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.txt >> HTML log: >> https://storage.kernelci.org//next/master/next-20190514/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.html >> Result: 691d4947face thermal: rockchip: fix up the tsadc pinctrl >> setting error >> >> Checks: >> revert: PASS >> verify: PASS >> >> Parameters: >> Tree: next >> URL: >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >> Branch: master >> Target: rk3288-veyron-jaq >> CPU arch: arm >> Lab: lab-collabora >> Compiler: gcc-8 >> Config: multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y >> Test suite: boot >> >> Breaking commit found: >> >> ------------------------------------------------------------------------------- >> commit 691d4947faceb8bd841900049e07c81c95ca4b0d >> Author: Elaine Zhang <zhangq...@rock-chips.com> >> Date: Tue Apr 30 18:09:44 2019 +0800 >> >> thermal: rockchip: fix up the tsadc pinctrl setting error >> >> Explicitly use the pinctrl to set/unset the right mode >> instead of relying on the pinctrl init mode. >> And it requires setting the tshut polarity before select pinctrl. >> >> When the temperature sensor mode is set to 0, it will automatically >> reset the board via the Clock-Reset-Unit (CRU) if the over temperature >> threshold is reached. However, when the pinctrl initializes, it does a >> transition to "otp_out" which may lead the SoC restart all the time. >> >> "otp_out" IO may be connected to the RESET circuit on the hardware. >> If the IO is in the wrong state, it will trigger RESET. >> (similar to the effect of pressing the RESET button) >> which will cause the soc to restart all the time. >> >> Signed-off-by: Elaine Zhang <zhangq...@rock-chips.com> >> Reviewed-by: Daniel Lezcano <daniel.lezc...@linaro.org> >> Signed-off-by: Eduardo Valentin <edubez...@gmail.com> > > I can confirm that the above commit breaks my jerry, though I haven't > dug into the details. :( Is anyone fixing? For now I'm just booting > with the revert. > > > -Doug
I can also confirm that this breaks boot on our custom board which is very similar to the rk3288-Firefly. In my scenario the processor just seems to "hang", no reset occurs if that helps debug matters. Regards, Jack. > > _______________________________________________ > Linux-rockchip mailing list > linux-rockc...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip >
