> -----Original Message-----
> From: Enric Balletbo i Serra [mailto:enric.balle...@collabora.com]
> Sent: Thursday, May 23, 2019 9:19 PM
> To: Mark Brown <broo...@kernel.org>; Eduardo Valentin
> <edubez...@gmail.com>; Elaine Zhang <zhangq...@rock-chips.com>
> Cc: tomeu.viz...@collabora.com; guillaume.tuc...@collabora.com;
> mga...@collabora.com; matthew.h...@linaro.org; khil...@baylibre.com;
> Daniel Lezcano <daniel.lezc...@linaro.org>; Heiko Stuebner
> <he...@sntech.de>; linux...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-rockc...@lists.infradead.org; Zhang, Rui
> <rui.zh...@intel.com>; linux-arm-ker...@lists.infradead.org
> Subject: Re: mainline/master boot bisection: v5.2-rc1-165-g54dee406374c on
> rk3288-veyron-jaq
> Importance: High
>
> Hi Mark,
>
> On 23/5/19 15:12, Mark Brown wrote:
> > On Wed, May 22, 2019 at 07:23:09PM -0700, kernelci.org bot wrote:
> >
> >> Details: https://kernelci.org/boot/id/5ce5984c59b514e6a47a364c
> >> Plain log: https://storage.kernelci.org//mainline/master/v5.2-rc1-165-
> g54dee406374c/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE
> =y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.txt
> >> HTML log: https://storage.kernelci.org//mainline/master/v5.2-rc1-165-
> g54dee406374c/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE
> =y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.html
> >> Result: 28694e009e51 thermal: rockchip: fix up the tsadc pinctrl
> >> setting
> error
> >
> > It looks like this issue has persisted for a while without any kind of
> > fix happening - given that the bisection has identified this commit as
> > causing the regression and confirmed that reverting it fixes shouldn't
> > we just revert? My guess would be that there's some error with the
> > pinctrl settings in the DT for the board.
> >
>
> After some discussion Heiko sent a patch that reverts the offending commit
> one day ago [1] and it's waiting for maintainer to pick-up the patch.
>
I thought Eduardo will take the patch.
But I will apply it and queue it for -rc2 anyway.
Thanks,
Rui
> The reason why we think is best reverting that fix it is explained here [2]
>
> [1] https://lkml.org/lkml/2019/5/22/467
> [2] https://lkml.org/lkml/2019/4/30/270
>
> Thanks,
> Enric
