On Wed, May 22, 2019 at 08:34:34AM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 22, 2019 at 7:12 AM Heiko Stuebner <he...@sntech.de> wrote: > > > > This reverts commit 28694e009e512451ead5519dd801f9869acb1f60. > > > > The commit causes multiple issues in that: > > - the added call to ->control does potentially run unclocked > > causing a hang of the machine > > - the added pinctrl-states are undocumented in the binding > > - the added pinctrl-states are not backwards compatible, breaking > > old devicetrees. > > > > Fixes: 28694e009e51 ("thermal: rockchip: fix up the tsadc pinctrl setting > > error") > > Signed-off-by: Heiko Stuebner <he...@sntech.de> > > --- > > drivers/thermal/rockchip_thermal.c | 36 +++--------------------------- > > 1 file changed, 3 insertions(+), 33 deletions(-) > > In case it helps with the urgency, there are lots of people who have > all independently needed to identify which commit stopped their boards > from booting mainline or broke temperature reading. I'm aware of at > least these reports: > > Reported-by: kernelci.org bot <b...@kernelci.org> > Reported-by: Enric Balletbo Serra <eballe...@gmail.com> > Reported-by: Vicente Bergas <vice...@gmail.com> > Reported-by: Jack Mitchell <m...@embed.me.uk> > Reported-by: Douglas Anderson <diand...@chromium.org> > > I can confirm that my board boots again after this revert, thus: > > Tested-by: Douglas Anderson <diand...@chromium.org>
I see. I can collect this revert if that is what unblocks you guys. Elaine, do you mind checking why these pinctrl changes are causing boot issues?