On Fri, 24 May 2019 09:00:27 +0000, Rasmus Villemoes <rasmus.villem...@prevas.dk> wrote: > These are almost identical to the 6185 variants, but have fewer bits > for the FID. > > Bit 10 of the VTU_OP register (offset 0x05) is the VidPolicy bit, > which one should probably preserve in mv88e6xxx_g1_vtu_op(), instead > of always writing a 0. However, on the 6352 family, that bit is > located at bit 12 in the VTU FID register (offset 0x02), and is always > unconditionally cleared by the mv88e6xxx_g1_vtu_fid_write() > function. > > Since nothing in the existing driver seems to know or care about that > bit, it seems reasonable to not add the boilerplate to preserve it for > the 6250 (which would require adding a chip-specific vtu_op function, > or adding chip-quirks to the existing one). > > Reviewed-by: Andrew Lunn <and...@lunn.ch> > Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk>
Reviewed-by: Vivien Didelot <vivien.dide...@gmail.com>
