Hi Weitao,
Weitao Hou <houweit...@gmail.com> wrote on Mon, 27 May 2019 20:14:40
+0800:
> since hdr was never used, we need not reserve and init it
What about "MTD oops 'hdr' header is never used, drop its
initialization."
Maybe a Fixes tag would be appropriate.
>
> Signed-off-by: Weitao Hou <houweit...@gmail.com>
> ---
> drivers/mtd/mtdoops.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
> index e078fc41aa61..6ae4b70ebdbb 100644
> --- a/drivers/mtd/mtdoops.c
> +++ b/drivers/mtd/mtdoops.c
> @@ -191,14 +191,8 @@ static void mtdoops_write(struct mtdoops_context *cxt,
> int panic)
> {
> struct mtd_info *mtd = cxt->mtd;
> size_t retlen;
> - u32 *hdr;
> int ret;
>
> - /* Add mtdoops header to the buffer */
> - hdr = cxt->oops_buf;
> - hdr[0] = cxt->nextcount;
> - hdr[1] = MTDOOPS_KERNMSG_MAGIC;
> -
> if (panic) {
> ret = mtd_panic_write(mtd, cxt->nextpage * record_size,
> record_size, &retlen, cxt->oops_buf);
Thanks,
Miquèl
