James Morris <jmor...@namei.org> wrote:

> > +
> > +   if (flags & ~KEYCTL_MOVE_EXCL)
> > +           return -EINVAL;
> > +
> > +   key_ref = lookup_user_key(id, KEY_LOOKUP_CREATE, KEY_NEED_LINK);
> > +   if (IS_ERR(key_ref)) {
> > +           ret = PTR_ERR(key_ref);
> > +           goto error;
> > +   }
> 
> This could probably be a simple return, as there is no cleanup.

Changed.

David

Reply via email to