On 6/3/19 4:56 PM, Ira Weiny wrote:
> On Mon, Jun 03, 2019 at 09:42:06AM -0700, Christoph Hellwig wrote:
>>> +#if defined(CONFIG_CMA)
>>
>> You can just use #ifdef here.
>>
>>> +static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
>>> + struct page **pages)
>>
>> Please use two instead of one tab to indent the continuing line of
>> a function declaration.
>>
>>> +{
>>> + if (unlikely(gup_flags & FOLL_LONGTERM)) {
>>
>> IMHO it would be a little nicer if we could move this into the caller.
>
> FWIW we already had this discussion and thought it better to put this here.
>
> https://lkml.org/lkml/2019/5/30/1565
>
> Ira
>
> [PS John for some reason your responses don't appear in that thread?]
Thanks for pointing out the email glitches! It looks like it's making it over to
lore.kernel.org/linux-mm, but not to lkml.org, nor to the lore.kernel.org/lkml
section either:
https://lore.kernel.org/linux-mm/e389551e-32c3-c9f2-2861-1a8819dc7...@nvidia.com/
...and I've already checked the DKIM signatures, they're all good. So I think
this
is getting narrowed down to, messages from nvidia.com (or at least from me) are
not
making it onto the lkml list server. I'm told that this can actually happen
*because*
of DKIM domains: list servers may try to avoid retransmitting from DKIM
domains. sigh.
Any hints are welcome, otherwise I'll try to locate the lkml admins and see
what can
be done.
(+Sanket, Ralph from our email team)
thanks,
--
John Hubbard
NVIDIA
