On Thu, Jun 06, 2019 at 10:32:48AM +0800, Chunfeng Yun wrote: > On Wed, 2019-06-05 at 14:44 +0200, Greg Kroah-Hartman wrote: > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and removed as needed. > > > > In order to properly do this, we need to load the common code before the > > usb core code, when everything is linked into the kernel, so reorder the > > link order of the code. > > > > Also as the usb common code has the possibility of the led trigger logic > > to be merged into it, handle the build option properly by only having > > one module init/exit function and have the common code initialize the > > led trigger if needed. > > > > Reported-by: Chunfeng Yun <[email protected]> > > Cc: Felipe Balbi <[email protected]> > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > --- > > Chunfeng, can you try testing this again? > > Tested-by: Chunfeng Yun <[email protected]> > > Thank you, Greg, Felipe
Thanks for the review, and all of the different iterations for this. For something so "simple" it sure took us all a number of tries :) I'll go queue it up now so that your future work can rely on it. thanks, greg k-h
