On Wed, Jun 5, 2019 at 10:13 PM Nathan Chancellor <[email protected]> wrote: > > Clang warns: > > sound/soc/codecs/rt1011.c:1291:12: warning: integer literal is too large > to be represented in type 'long', interpreting as 'unsigned long' per > C89; this literal will have type 'long long' in C99 onwards > [-Wc99-compat] > format = 2147483648; /* 2^24 * 128 */
This number's bitpattern is a leading one followed by 31 zeros. `format` is declared as `unsigned int`, and literals in C are signed unless suffixed, so this patch LGTM. Maybe a macro declaring such a bitpattern would improve readability over the existing magic constant and comment? Reviewed-by: Nick Desaulniers <[email protected]> > ^ > sound/soc/codecs/rt1011.c:2123:13: warning: integer literal is too large > to be represented in type 'long', interpreting as 'unsigned long' per > C89; this literal will have type 'long long' in C99 onwards > [-Wc99-compat] > format = 2147483648; /* 2^24 * 128 */ > ^ > 2 warnings generated. > > Mark the integer literals as unsigned explicitly so that if the kernel > does ever bump the C standard it uses, the behavior is consitent. s/consitent/consistent/ :set spell :P -- Thanks, ~Nick Desaulniers
