Hi Nicolas, Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > This enables on both multi_v7_defconfig and bcm2835_defconfig the new > firmware based clock and cpufreq drivers for the Raspberry Pi platform. > > In the case of bcm2835_defconfig, as the cpufreq subsystem was disabled, > the subsystem configuration was copied from multi_v7_defconfig (default > governor, statistics, etc...). sorry i didn't made any suggestions for this. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulie...@suse.de> > --- > arch/arm/configs/bcm2835_defconfig | 9 +++++++++ > arch/arm/configs/multi_v7_defconfig | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/arch/arm/configs/bcm2835_defconfig > b/arch/arm/configs/bcm2835_defconfig > index dcf7610cfe55..3fd90bfd5fec 100644 > --- a/arch/arm/configs/bcm2835_defconfig > +++ b/arch/arm/configs/bcm2835_defconfig > @@ -37,6 +37,14 @@ CONFIG_CMA=y > CONFIG_SECCOMP=y > CONFIG_KEXEC=y > CONFIG_CRASH_DUMP=y > +CONFIG_CPU_FREQ=y > +CONFIG_CPU_FREQ_STAT=y > +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y >From my understanding ondemand isn't the best fit for Raspberry Pi. I would prefer conservative because of the delays through the mailbox interface but it's not a really strong opinion. > +CONFIG_CPU_FREQ_GOV_POWERSAVE=m > +CONFIG_CPU_FREQ_GOV_USERSPACE=m > +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=m
Please make them builtin in this case. After that you can have make Acked-by for this patch. > +CONFIG_CPUFREQ_DT=y > +CONFIG_ARM_RASPBERRYPI_CPUFREQ=y > CONFIG_VFP=y > # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set > # CONFIG_SUSPEND is not set > @@ -132,6 +140,7 @@ CONFIG_DMA_BCM2835=y > CONFIG_STAGING=y > CONFIG_SND_BCM2835=m > CONFIG_VIDEO_BCM2835=m > +CONFIG_CLK_RASPBERRYPI=y > CONFIG_MAILBOX=y > CONFIG_BCM2835_MBOX=y > # CONFIG_IOMMU_SUPPORT is not set > diff --git a/arch/arm/configs/multi_v7_defconfig > b/arch/arm/configs/multi_v7_defconfig > index 6b748f214eae..0fd60a83f768 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -102,6 +102,7 @@ CONFIG_CPU_FREQ_GOV_CONSERVATIVE=m > CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y > CONFIG_CPUFREQ_DT=y > CONFIG_ARM_IMX6Q_CPUFREQ=y > +CONFIG_ARM_RASPBERRYPI_CPUFREQ=y > CONFIG_QORIQ_CPUFREQ=y > CONFIG_CPU_IDLE=y > CONFIG_ARM_CPUIDLE=y > @@ -899,6 +900,7 @@ CONFIG_STAGING_BOARD=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_COMMON_CLK_RK808=m > CONFIG_COMMON_CLK_S2MPS11=m > +CONFIG_CLK_RASPBERRYPI=y > CONFIG_COMMON_CLK_QCOM=y > CONFIG_QCOM_CLK_RPM=y > CONFIG_APQ_MMCC_8084=y
