Em Tue, Jun 11, 2019 at 03:09:07PM +0100, Mark Rutland escreveu: > On Tue, Jun 11, 2019 at 01:53:09PM +0100, Raphael Gault wrote: > > In order to subsequently add more tests for the arm64 architecture > > we compile the tests target for arm64 systematically. > > Given prior questions regarding this commit, it's probably worth > spelling things out more explicitly, e.g. > > Currently we only build the arm64/tests directory if > CONFIG_DWARF_UNWIND is selected, which is fine as the only test we > have is arm64/tests/dwarf-unwind.o. > > So that we can add more tests to the test directory, let's > unconditionally build the directory, but conditionally build > dwarf-unwind.o depending on CONFIG_DWARF_UNWIND. > > There should be no functional change as a result of this patch. > > > > > Signed-off-by: Raphael Gault <raphael.ga...@arm.com> > > Either way, the patch looks good to me: > > Acked-by: Mark Rutland <mark.rutl...@arm.com>
I'll update the comment, collect your Acked-by and apply the patch. - Arnaldo > Mark. > > > --- > > tools/perf/arch/arm64/Build | 2 +- > > tools/perf/arch/arm64/tests/Build | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/arch/arm64/Build b/tools/perf/arch/arm64/Build > > index 36222e64bbf7..a7dd46a5b678 100644 > > --- a/tools/perf/arch/arm64/Build > > +++ b/tools/perf/arch/arm64/Build > > @@ -1,2 +1,2 @@ > > perf-y += util/ > > -perf-$(CONFIG_DWARF_UNWIND) += tests/ > > +perf-y += tests/ > > diff --git a/tools/perf/arch/arm64/tests/Build > > b/tools/perf/arch/arm64/tests/Build > > index 41707fea74b3..a61c06bdb757 100644 > > --- a/tools/perf/arch/arm64/tests/Build > > +++ b/tools/perf/arch/arm64/tests/Build > > @@ -1,4 +1,4 @@ > > perf-y += regs_load.o > > -perf-y += dwarf-unwind.o > > +perf-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o > > > > perf-y += arch-tests.o > > -- > > 2.17.1 > > -- - Arnaldo
