Re: [PATCH net-next v2 1/2] hinic: add rss support

[Jakub Kicinski]

On Tue, 11 Jun 2019 18:12:33 +0000, Xue Chaojing wrote:
> +     for (i = 0; i < HINIC_RSS_INDIR_SIZE; i++)
> +             indir_tbl[i] = (i / HINIC_RSS_INDIR_SIZE) * nic_dev->num_rss +
> +                             i % nic_dev->num_rss;

This looks suspicious:

        i is in range [0, HINIC_RSS_INDIR_SIZE)
        so i / HINIC_RSS_INDIR_SIZE is always 0

For the rest please use ethtool_rxfh_indir_default()