Hi Linus, On Sat, Jun 15, 2019 at 11:08 AM Linus Walleij <[email protected]> wrote: > > Hi Martin! > > Thanks for fixing this up! you're welcome I think I finally understand why you want to switch everything over to GPIO descriptors
> A hint for a follow-up: > > On Wed, Jun 12, 2019 at 9:31 PM Martin Blumenstingl > <[email protected]> wrote: > > > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > > index 4335bd771ce5..816edb545592 100644 > > --- a/include/linux/stmmac.h > > +++ b/include/linux/stmmac.h > > @@ -97,7 +97,7 @@ struct stmmac_mdio_bus_data { > > int *irqs; > > int probed_phy_irq; > > #ifdef CONFIG_OF > > - int reset_gpio, active_low; > > + int reset_gpio; > > Nothing in the kernel seems to be using this reset_gpio either. > > I think it can be deleted with associated code, any new users > should use machine descriptors if they insist on board files. good catch, thank you - I'll put that in my cleanup series that I want to send anyways Martin
