On Mon, Jun 03, 2019 at 09:29:44PM +0800, Peter Xu wrote: > get_target_base() in the timer code is not using the "base" parameter > at all. My gut feeling is that instead of removing that extra > parameter, what we really want to do is "return the old base if it > does not suite for a new one".
Ping? Note that as reference hrtimer is using the same logic as in this patch. > > CC: Thomas Gleixner <t...@linutronix.de> > CC: John Stultz <john.stu...@linaro.org> > CC: Stephen Boyd <sb...@kernel.org> > CC: Luiz Capitulino <lcapitul...@redhat.com> > CC: Marcelo Tosatti <mtosa...@redhat.com> > CC: linux-kernel@vger.kernel.org > Signed-off-by: Peter Xu <pet...@redhat.com> > --- > kernel/time/timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/timer.c b/kernel/time/timer.c > index 343c7ba33b1c..6ff6ffd2c719 100644 > --- a/kernel/time/timer.c > +++ b/kernel/time/timer.c > @@ -868,7 +868,7 @@ get_target_base(struct timer_base *base, unsigned tflags) > !(tflags & TIMER_PINNED)) > return get_timer_cpu_base(tflags, get_nohz_timer_target()); > #endif > - return get_timer_this_cpu_base(tflags); > + return base; > } > > static inline void forward_timer_base(struct timer_base *base) > -- > 2.17.1 > Regards, -- Peter Xu
