On Mon, Jun 17, 2019 at 08:21:27PM +0200, Enrico Weigelt, metux IT consult wrote: > From: Enrico Weigelt <[email protected]> > > Add more helper macros for trivial driver init cases, similar to the > already existing module_platform_driver or module_i2c_driver().
Inconsistent use of () after macro names. Other than that (and my remark for patch 2) I'm ok with this series. Usually Greg (on Cc:) merges siox stuff, but I don't expect anything to happen which conflicts with this series so I think it's fine if both patches go in via the gpio tree. > + > +/* module_siox_driver() - Helper macro for drivers that don't do > + * anything special in module init/exit. This eliminates a lot of > + * boilerplate. Each module may only use this macro once, and Given there is only one siox driver in the tree, "a lot" seems bold, but I don't mind it. > + * calling it replaces module_init() and module_exit() > + */ > +#define module_siox_driver(__siox_driver) \ > + module_driver(__siox_driver, siox_driver_register, \ > + siox_driver_unregister) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
