Re: [PATCH v3 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver

[Greg Kroah-Hartman]

On Sun, Jun 16, 2019 at 09:19:49AM -0700, Shobhit Kukreti wrote:
> Cleaned up the code from the following files to get rid of
> check patch error "that open brace { should be on the previous line"
> 
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> drivers/staging/rtl8723bs/os_dep/recv_linux.c
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c
> 
> Signed-off-by: Shobhit Kukreti <shobhitkukr...@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/mlme_linux.c     | 15 +++--
>  drivers/staging/rtl8723bs/os_dep/recv_linux.c     | 77 
> ++++++++---------------
>  drivers/staging/rtl8723bs/os_dep/rtw_proc.c       |  6 +-
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c      | 15 ++---
>  drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 24 +++----
>  5 files changed, 49 insertions(+), 88 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c 
> b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> index aa2499f..4631b68 100644
> --- a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> @@ -46,8 +46,7 @@ void rtw_os_indicate_connect(struct adapter *adapter)
>       struct mlme_priv *pmlmepriv = &(adapter->mlmepriv);
>  
>       if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) ||
> -             (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true))
> -     {
> +             (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
>               rtw_cfg80211_ibss_indicate_connect(adapter);
>       }
>       else
> @@ -77,8 +76,8 @@ void rtw_reset_securitypriv(struct adapter *adapter)
>  
>       spin_lock_bh(&adapter->security_key_mutex);
>  
> -     if (adapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X)/* 
> 802.1x */
> -     {
> +     if (adapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) { 
> /* 802.1x */
> +

Why the blank line?

And don't keep the comment on the right side, that's just a pain to work
with.

thanks,

greg k-h