On Tue, Jun 18, 2019 at 10:15:11AM -0600, Shuah Khan wrote: > On 6/18/19 10:08 AM, Greg KH wrote: > > On Tue, Jun 18, 2019 at 05:19:47PM +0530, Puranjay Mohan wrote: > > > Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed > > > 32-bit value by 31 bits problem. This isn't a problem for kernel builds > > > with gcc. > > > > > > This could be problem since this header is part of public API which > > > could be included for builds using compilers that don't handle this > > > condition safely resulting in undefined behavior. > > > > > > Signed-off-by: Puranjay Mohan <[email protected]> > > > > Reviewed-by: Greg Kroah-Hartman <[email protected]> > > > > You should resend this and cc: Nicolas Pitre <[email protected]> as he is > > the cramfs maintainer. > > > > Puranjay! You can add all the Reviewed-by tags when you resend the patch > with Nicolas Pitre <[email protected]> on the thread. > > > Reviewed-by: Shuah Khan <[email protected]> > > thanks, > -- Shuah
Thanks, I have sent the mail with Nicolas Pitre in CC. --Puranjay
