On Wed 19-06-19 10:00:06, Colin King wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> Pointer 'node' is assigned a value that is never read, node is
> later overwritten when it re-assigned a different value inside
> the while-loop. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/ext4/extents_status.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index 023a3eb3afa3..7521de2dcf3a 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -1317,7 +1317,6 @@ static int es_do_reclaim_extents(struct ext4_inode_info
> *ei, ext4_lblk_t end,
> es = __es_tree_search(&tree->root, ei->i_es_shrink_lblk);
> if (!es)
> goto out_wrap;
> - node = &es->rb_node;
> while (*nr_to_scan > 0) {
> if (es->es_lblk > end) {
> ei->i_es_shrink_lblk = end + 1;
> --
> 2.20.1
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
