On Thu, Jun 20, 2019 at 05:56:32AM +0000, Parshuram Raju Thombare wrote: > For in band mode, I see two places to config MAC speed > and duplex mode, 1. mac_link_state 2. mac_link_up. In mac_link_up, though > state > read from mac_link_state is passed, it is only used for printing log and > updating > pl->cur_interface, so if configuring MAC speed/duplex mode in mac_link_up is > correct, > these parameters will need to read again from HW.
That is incorrect. Again, please read the phylink documentation. There is even an article on how to convert drivers. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up