On Mon, Jun 03, 2019 at 04:18:30PM -0700, Florian Fainelli wrote: > asm/smp.h is included by linux/smp.h and some drivers, in particular > irqchip drivers can access cpu_logical_map[] in order to perform SMP > affinity tasks. Make arm64 consistent with other architectures here. > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
I merged this last night, and it causes ojn's builder to fail 98 defconfigs with errors like: arch/arm/include/asm/smp_plat.h:79:7: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration] arch/arm/kernel/setup.c:594:21: error: lvalue required as left operand of assignment arch/arm/kernel/setup.c:596:22: error: lvalue required as left operand of assignment Dropping this patch. Also, you may wish to make the patch description refer to the correct architecture. > --- > arch/arm/include/asm/smp.h | 6 ++++++ > arch/arm/include/asm/smp_plat.h | 5 ----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/include/asm/smp.h b/arch/arm/include/asm/smp.h > index 451ae684aaf4..112d78e82f35 100644 > --- a/arch/arm/include/asm/smp.h > +++ b/arch/arm/include/asm/smp.h > @@ -20,6 +20,12 @@ > > #define raw_smp_processor_id() (current_thread_info()->cpu) > > +/* > + * Logical CPU mapping. > + */ > +extern u32 __cpu_logical_map[]; > +#define cpu_logical_map(cpu) __cpu_logical_map[cpu] > + > struct seq_file; > > /* > diff --git a/arch/arm/include/asm/smp_plat.h b/arch/arm/include/asm/smp_plat.h > index f2c36acf9886..ca6b91d400cf 100644 > --- a/arch/arm/include/asm/smp_plat.h > +++ b/arch/arm/include/asm/smp_plat.h > @@ -66,11 +66,6 @@ static inline int cache_ops_need_broadcast(void) > } > #endif > > -/* > - * Logical CPU mapping. > - */ > -extern u32 __cpu_logical_map[]; > -#define cpu_logical_map(cpu) __cpu_logical_map[cpu] > /* > * Retrieve logical cpu index corresponding to a given MPIDR[23:0] > * - mpidr: MPIDR[23:0] to be used for the look-up > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
