On 2019-06-24 10:34, Suzuki K Poulose wrote:
> Hi Peter,
>
> On 22/06/2019 06:25, Peter Rosin wrote:
>> On 2019-06-14 19:54, Suzuki K Poulose wrote:
>>> Add a wrapper to class_find_device() to search for a device
>>> by the of_node pointer, reusing the generic match function.
>>> Also convert the existing users to make use of the new helper.
>>>
>>> Cc: Alan Tull <at...@kernel.org>
>>> Cc: Moritz Fischer <m...@kernel.org>
>>> Cc: linux-f...@vger.kernel.org
>>> Cc: Peter Rosin <p...@axentia.se>
>>> Cc: Mark Brown <broo...@kernel.org>
>>> Cc: Florian Fainelli <f.faine...@gmail.com>
>>> Cc: Heiner Kallweit <hkallwe...@gmail.com>
>>> Cc: "David S. Miller" <da...@davemloft.net>
>>> Cc: Andrew Lunn <and...@lunn.ch>
>>> Cc: Liam Girdwood <lgirdw...@gmail.com>
>>> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
>>> Cc: "Rafael J. Wysocki" <raf...@kernel.org>
>>> Cc: Jiri Slaby <jsl...@suse.com>
>>> Acked-by: Mark Brown <broo...@kernel.org>
>>> Reviewed-by: Andrew Lunn <and...@lunn.ch>
>>> Reviewed-by: Peter Rosin <p...@axentia.se>
>>
>> Whoooa! I reviewed only the drivers/mux/core.c changes when this was done
>> in a series of much smaller patches. This tag makes it seem as if I have
>> reviewed the whole thing, which I had not done when you added this tag out
>> of the blue.
>
> Apologies for the surprise. The patch was simply squashed with the change that
> introduced the "helper" to better aid the reviewers, based on suggestions on
> the
> list. I kept your tags, only because there were no changes, but some
> additional
> context on the core driver.
You could e.g. have written:
...
[For the drivers/mux/core.c part]
Reviewed-by: Peter Rosin <p...@axentia.se>
...
>>
>> Now, this stuff is trivial and by now I have looked at the other files
>> and it all seems simple enough. So, you can keep the tag, but it is NOT
>> ok to handle tags like you have done here.
>
> Sure, I will keep that in mind.
Great!
Cheers,
Peter
