Re: [RFC PATCH 2/6] bpf: add BPF_MAP_DUMP command to access more than one entry per call

[Jakub Kicinski]

On Fri, 21 Jun 2019 16:16:46 -0700, Brian Vazquez wrote:
> @@ -385,6 +386,14 @@ union bpf_attr {
>               __u64           flags;
>       };
>  
> +     struct { /* struct used by BPF_MAP_DUMP command */
> +             __u32           map_fd;

There is a hole here, perhaps flags don't have to be 64 bit?

> +             __aligned_u64   prev_key;
> +             __aligned_u64   buf;
> +             __aligned_u64   buf_len; /* input/output: len of buf */
> +             __u64           flags;
> +     } dump;
> +
>       struct { /* anonymous struct used by BPF_PROG_LOAD command */
>               __u32           prog_type;      /* one of enum bpf_prog_type */
>               __u32           insn_cnt;