Hi, Am Dienstag, 25. Juni 2019, 09:46:12 CEST schrieb Jose Abreu: > From: Katsuhiro Suzuki <katsuh...@katsuster.net> > > > I checked drivers/net/ethernet/stmicro/stmmac/stmmac_main.c and found > > stmmac_init_phy() is going to fail if ethernet device node does not > > have following property: > > - phy-handle > > - phy > > - phy-device > > > > This commit broke the device-trees such as TinkerBoard. The mdio > > subnode creating a mdio bus is changed to required or still optional? > > Yeah, with PHYLINK the PHY binding is always required ... > > How do you want to proceed ? I think DT bindings can never break between > releases so I will probably need to cook a patch for stmmac.
Correct ... old devicetrees on new kernels should not break. Especially as this affects a big number of boards potentially loosing network support and in the devicetree binding the phy property is also marked as optional. Heiko
