Wed, Jun 26, 2019 at 10:08:44AM CEST, [email protected] wrote: >We build vlan on top of bonding interface, which vlan offload >is off, bond mode is 802.3ad (LACP) and xmit_hash_policy is >BOND_XMIT_POLICY_ENCAP34. > >Because vlan tx offload is off, vlan tci is cleared and skb push >the vlan header in validate_xmit_vlan() while sending from vlan >devices. Then in bond_xmit_hash, __skb_flow_dissect() fails to >get information from protocol headers encapsulated within vlan, >because 'nhoff' is points to IP header, so bond hashing is based >on layer 2 info, which fails to distribute packets across slaves. > >This patch always enable bonding's vlan tx offload, pass the vlan >packets to the slave devices with vlan tci, let them to handle >vlan implementation. > >Fixes: 278339a42a1b ("bonding: propogate vlan_features to bonding master") >Suggested-by: Jiri Pirko <[email protected]> >Signed-off-by: YueHaibing <[email protected]>
Acked-by: Jiri Pirko <[email protected]> Could you please do the same for team? Thanks!
