* Thomas Gleixner <t...@linutronix.de> wrote:

> When reviewing the HPET NMI watchdog series, I stared into the HPET code
> and the proposed changes. The latter try to add yet another layer of duct
> tape and ifdeffery to the existing maze. No, thanks.
> 
> The following series cleans up the channel management and consolidates all
> state storage into a single place instead of 3 different ad hoc allocated
> places which carry redundant information and make the code hard to follow.
> 
> The reservation of a HPET channel for a NMI watchdog becomes a few lines of
> code after that series and just fits naturaly into that scheme without glue
> and more extra storage and ifdeffery.
> 
> For your conveniance the series is also available from git:
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/hpet
> 
> Thanks,
> 
>       tglx
> 
> 8<---------------------
>  include/asm/hpet.h |    7 
>  kernel/apic/msi.c  |    4 
>  kernel/hpet.c      |  937 
> +++++++++++++++++++++++------------------------------
>  3 files changed, 428 insertions(+), 520 deletions(-)

Modulo the minor nits I just posted, all the other patches (not written 
by me) are looking good:

  Reviewed-by: Ingo Molnar <mi...@kernel.org>

Thanks,

        Ingo

Reply via email to