Hi Ivan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    
https://github.com/0day-ci/linux/commits/Ivan-Khoronzhuk/xdp-xdp_umem-fix-umem-pages-mapping-for-32bits-systems/20190627-135949
config: x86_64-randconfig-x004-201925 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-9) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All error/warnings (new ones prefixed by >>):

   net//xdp/xdp_umem.c: In function 'xdp_umem_unmap_pages':
>> net//xdp/xdp_umem.c:177:3: error: implicit declaration of function 'kunmap'; 
>> did you mean 'vunmap'? [-Werror=implicit-function-declaration]
      kunmap(umem->pgs[i]);
      ^~~~~~
      vunmap
   net//xdp/xdp_umem.c: In function 'xdp_umem_reg':
>> net//xdp/xdp_umem.c:384:25: error: implicit declaration of function 'kmap'; 
>> did you mean 'bmap'? [-Werror=implicit-function-declaration]
      umem->pages[i].addr = kmap(umem->pgs[i]);
                            ^~~~
                            bmap
>> net//xdp/xdp_umem.c:384:23: warning: assignment makes pointer from integer 
>> without a cast [-Wint-conversion]
      umem->pages[i].addr = kmap(umem->pgs[i]);
                          ^
   cc1: some warnings being treated as errors

vim +177 net//xdp/xdp_umem.c

   171  
   172  static void xdp_umem_unmap_pages(struct xdp_umem *umem)
   173  {
   174          unsigned int i;
   175  
   176          for (i = 0; i < umem->npgs; i++)
 > 177                  kunmap(umem->pgs[i]);
   178  }
   179  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to