Hi Colin, Colin King <[email protected]> wrote on Tue, 4 Jun 2019 11:58:59 +0100:
> From: Colin Ian King <[email protected]> > > The variable block_size is being assigned to itself and to > geo->ecc_chunk_size. Clean up the double assignment by removing > the assignment to itself. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > index 5db84178edff..334fe3130285 100644 > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > @@ -1428,7 +1428,7 @@ static void gpmi_bch_layout_std(struct gpmi_nand_data > *this) > struct bch_geometry *geo = &this->bch_geometry; > unsigned int ecc_strength = geo->ecc_strength >> 1; > unsigned int gf_len = geo->gf_len; > - unsigned int block_size = block_size = geo->ecc_chunk_size; > + unsigned int block_size = geo->ecc_chunk_size; > > this->bch_flashlayout0 = > BF_BCH_FLASH0LAYOUT0_NBLOCKS(geo->ecc_chunk_count - 1) | Applied to nand/next, thanks. Miquèl Thanks, Miquèl
