On Mon 27-05-19 13:11:43, David Hildenbrand wrote: > ZONE_DEVICE is not yet supported, fail if an altmap is passed, so we > don't forget arch_add_memory()/arch_remove_memory() when unlocking > support.
Why do we need this? Sure ZONE_DEVICE is not supported for s390 and so might be the case for other arches which support hotplug. I do not see much point in adding warning to each of them. > Cc: Martin Schwidefsky <schwidef...@de.ibm.com> > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: Michal Hocko <mho...@suse.com> > Cc: Mike Rapoport <r...@linux.vnet.ibm.com> > Cc: David Hildenbrand <da...@redhat.com> > Cc: Vasily Gorbik <g...@linux.ibm.com> > Cc: Oscar Salvador <osalva...@suse.com> > Suggested-by: Dan Williams <dan.j.willi...@intel.com> > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > arch/s390/mm/init.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c > index 14d1eae9fe43..d552e330fbcc 100644 > --- a/arch/s390/mm/init.c > +++ b/arch/s390/mm/init.c > @@ -226,6 +226,9 @@ int arch_add_memory(int nid, u64 start, u64 size, > unsigned long size_pages = PFN_DOWN(size); > int rc; > > + if (WARN_ON_ONCE(restrictions->altmap)) > + return -EINVAL; > + > rc = vmem_add_mapping(start, size); > if (rc) > return rc; > -- > 2.20.1 > -- Michal Hocko SUSE Labs
