If "hotplug_bridges == 0", "!dev->is_hotplug_bridge" is always true, so the
loop that divides the remaining resources among hotplug-capable bridges
does nothing.

Check for "hotplug_bridges == 0" earlier, so we don't even have to compute
the amount of remaining resources.  No functional change intended.

Signed-off-by: Nicholas Johnson <nicholas.johnson-opensou...@outlook.com.au>
---
 drivers/pci/setup-bus.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index af28af898..04adeebe8 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -1887,6 +1887,9 @@ static void pci_bus_distribute_available_resources(struct 
pci_bus *bus,
                return;
        }
 
+       if (hotplug_bridges == 0)
+               return;
+
        /*
         * Calculate the total amount of extra resource space we can
         * pass to bridges below this one.  This is basically the
@@ -1936,8 +1939,6 @@ static void pci_bus_distribute_available_resources(struct 
pci_bus *bus,
                 * Distribute available extra resources equally between
                 * hotplug-capable downstream ports taking alignment into
                 * account.
-                *
-                * Here hotplug_bridges is always != 0.
                 */
                align = pci_resource_alignment(bridge, io_res);
                io = div64_ul(available_io, hotplug_bridges);
-- 
2.20.1

Reply via email to