On 6/18/19 9:16 AM, Vineet Gupta wrote: > On 6/14/19 9:41 AM, Eugeniy Paltsev wrote: >> Implement jump label patching for ARC. Jump labels provide >> an interface to generate dynamic branches using >> self-modifying code. >> >> This allows us to implement conditional branches where >> changing branch direction is expensive but branch selection >> is basically 'free' >> >> This implementation uses 32-bit NOP and BRANCH instructions >> which forced to be aligned by 4 to guarantee that they don't >> cross L1 cache line and can be update atomically. >> >> Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> > LGTM overall - nits below. >
Can you address the review comments soon so this gets merged in 5.3 whose merge window is looming !
